1106060 - Firefox can't update if addons installed will be incompatible in the updated version

Status: RESOLVED DUPLICATE of bug 1100346

(Firefox :: General, defect)

Description

[Cosmin Malutan, [:cosmin-malutan]]

Steps:
1 Download an older version of Firefox, let's say Nightly 32:
  > ftp://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/05/2014-05-01-03-02-02-mozilla-central/
2 Install an addon that it won't be compatible after the update:
  > https://addons.mozilla.org/en-US/firefox/addon/super-tab-mode/
3 Go to Menu > Help > About
4 Click on "Check for Updates"

Expected: Firefox will check for updates

Actual result: "Restart to Update" button will appear which does nothing




The reason we didn't caught this in our update tests is because the old Software:Update UI checks for incompatible addons and tells the user that those will be disabled.
To prompt the old UI call the function below in Error Console:
Components.classes["@mozilla.org/updates/update-prompt;1"].createInstance(Components.interfaces.nsIUpdatePrompt).checkForUpdates()

Comment 1

[Cosmin Malutan, [:cosmin-malutan]]

This doesn't reproduce all the time, but I can hit the issue if I open an cleanly new extracted Firefox with an profile that already has the addon.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Cosmin Malutan from comment #0)
> Actual result: "Restart to Update" button will appear which does nothing

Do you see any failure in the browser console? This might be helpful to indicate where the problem is.

Also does Firefox update when you restart it yourself without the button?

Comment 3

[Cosmin Malutan, [:cosmin-malutan]]

Attachment: video.ogv

I have nothing in console, I attached an video.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This video does not show that you opened the browser console for possible js errors.

Comment 5

[Cosmin Malutan, [:cosmin-malutan]]

This is when I open the Firefox with the addon added via mozprofile. This is what happen in our update test when I tried to check the bug 599290 with an incompatible addon. 
In console I'we get a warning that getPreventDefault is deprecated.

https://www.youtube.com/watch?v=jFWyb7jqN2o&feature=youtu.be(In reply to Cosmin Malutan from comment #3)
> Created attachment 8530300 [details]
> video.ogv
> 
> I have nothing in console, I attached an video.

Comment 6

[Robert Strong (they/them - no direct email)]

I believe this is a dupe of an earlier filed bug in Firefox -> General. It also has a couple of bugs that likely regressed this. This is Firefox ui and not part of toolkit so moving to correct component.

Comment 7

[Robert Strong (they/them - no direct email)]

Likely a dupe of bug 1100346